-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a nuget package #20
base: master
Are you sure you want to change the base?
Conversation
It looks like you created a new target but didn't put it in any dependency
|
@forki I took it out because it was failing. Try doing a straight up build and you'll see the unit test project fails to build. But if you build from Visual Studio, it succeeds. |
After updating the xunit runners to 2.0 and FAKE to 3.26.7 (and some minor script adjustments) the tests seem to pass but the script still fails.
The tests output also seems to indicate that the tests passed
|
Looks as if it was failing because it was trying to run the test assemblies found in the Debug folder after it ran the Release ones. Narrowing the file selection to |
In summary, update xunit runners to 2.0, update FAKE to 3.26.7 (need this for the xUnit2Helper) |
Thanks for that investigative work @pmacn! Want to send a PR for that? |
I'll get one up later today |
This should be fine to just rebase onto master and possibly adding On a completely different note. Starting a new job on Monday which will mean that desktop development goes 📉 and web development goes 📈 |
Feel free!
😢 Well thank you for all your help so far! And congrats on the new job! |
Started the work to automatically build NuGet packages. I'm running into a weird problem with how we script the build. I'm using FAKE with FODY and the two don't seem to get along. I think FAKE is building the solution without running the targets that FODY needs to have run beforehand. I don't have time to look into this now.
But maybe @forki or @distantcam will have an idea off the top of their heads? 😄